Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing MultiRabbit Bootstrap #1302

Closed
rwanderc opened this issue Jan 31, 2021 · 1 comment
Closed

Introducing MultiRabbit Bootstrap #1302

rwanderc opened this issue Jan 31, 2021 · 1 comment

Comments

@rwanderc
Copy link
Contributor

Enhancement

Hi Spring Team,
I'm creating this issue to propose some changes for your review:

  • Creation of the MultiRabbitBootstrapConfiguration, activated via properties, since the default RabbitListenerBPP bean cannot be overridden with auto-config.
  • Injection of the MultiRabbit admin to the RabbitListener, before it's processed by RabbitListenerBPP, so as to have the bean resolved and assigned to the MethodRabbitListenerEndpoint. It fixes an issue lately found on the order of loading where the MultiRabbitAutoConfig (at boot) was not being processed before MultiRabbitBPP starts the postProcessAfterInitialization(), which leads to bean not found.
  • Move some configs to RabbitListenerConfigUtils as they are shared among Rabbit and MultiRabbit, as well as used in the boot.
rwanderc added a commit to rwanderc/spring-amqp that referenced this issue Jan 31, 2021
@rwanderc
spring-projectsGH-1302 Introduced MultiRabbitBootstrapConfiguration t…
e20758b 
…o register MultiRabbitBPP
rwanderc added a commit to rwanderc/spring-amqp that referenced this issue Jan 31, 2021
@rwanderc
spring-projectsGH-1302 Injecting admin at RabbitListener so as be res…
db1b633 
…olved for the RabbitListenerEndpoint
garyrussell pushed a commit that referenced this issue Feb 8, 2021
@rwanderc
Introducing MultiRabbit Bootstrap (#1303)
692713d 
* GH-1302 Introduced MultiRabbitBootstrapConfiguration to register MultiRabbitBPP

* GH-1302 Injecting admin at RabbitListener so as be resolved for the RabbitListenerEndpoint
@garyrussell
Copy link
Contributor

Thanks @rwanderc

In future, please add Resolves https://github.com/spring-projects/spring-amqp/issues/1302 in the first commit comment so that the issue will auto-close when the PR is merged.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garyrussell @rwanderc