Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use basic.nack (RabbitMQ extension) [AMQP-171] #1732

Closed
spring-operator opened this issue Jun 1, 2011 · 1 comment
Closed

Do not use basic.nack (RabbitMQ extension) [AMQP-171] #1732

spring-operator opened this issue Jun 1, 2011 · 1 comment
Assignees
@dsyer
Labels
type: enhancement
Milestone
1.0.0.RC2

Comments

@spring-operator
Copy link
Contributor

spring-operator commented Jun 1, 2011 •
edited
Loading

Dave Syer opened AMQP-171 and commented

#1729 was a decent improvement in efficiency and performance, but it relies on basic.nack. Probably we need a way to switch that off at least.

Affects: 1.2.0.RC1
@spring-operator
Copy link
Contributor Author

Dave Syer commented

Moved most of the commit/rollback responsibility in SMLC to the consumer - that way it can collect delivery tags and bulk reject them if necessary.

@spring-operator spring-operator mentioned this issue Feb 13, 2023
Closed
onobc pushed a commit to onobc/spring-amqp that referenced this issue Feb 22, 2023
@garyrussell @artembilan
spring-projectsGH-1732: Fix Listener Container Parser
9371f8c 
Resolves spring-projects#1372

Do not split `queue-names` in the parser - leave it to Spring's type converter.
Also support SpEL in `queues`; a more elegant solution would require major
refactoring of the parser; so this is just a compromise.

**cherry-pick to 2.3.x, 2.2.x**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsyer dsyer

Labels
type: enhancement
Projects
None yet
Milestone
1.0.0.RC2
Development

No branches or pull requests
2 participants
@dsyer @spring-operator