Use of PluginBuilderFactory on AmqpAppender (Log4j2)

[Scip88]

resolves #1142

Refactor "@ PluginFactory" and use of "@ PluginBuilderFactory"

Use of PluginBuilderFactory simplifies subclasses' implementations of AmqpAppender (Log4j2)

[pivotal-issuemaster]

@Scip88 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-issuemaster]

@Scip88 Thank you for signing the Contributor License Agreement!

[artembilan]

@Scip88 ,

Thank you for contribution!

Use of PluginBuilderFactory simplifies subclasses' implementations of AmqpAppender

Would you mind to demonstrate such a feature in the tests? For example, AmqpAppenderTests is aimed for an AmqpAppender coverage.

Also, it sounds like Docs (logging.adoc) deserves some attention with this change...

[Scip88]

@artembilan,
no new test are needed, this is a refactor and tests from the same AmqpAppenderTest class from package org.springframework.amqp.rabbit.log4j2 are sufficient.

As indicated in Plugin Builder, the Log4j2 core initializes an Appender (as other log4j plugin) via two possible static methods: @PluginBuilderFactory or @PluginFactory

I'm working on logging.adoc

[Scip88]

@artembilan I've update logging.adoc, please take a look

[artembilan]

no new test are needed

Then why do we do this change at all?
Seems for me you have claimed that with a @PluginBuilderFactory it is going to be easier to extend an AmqpAppender functionality.
So, confirm with a test, please, that we are good to go with the fix.

Thanks

[artembilan]

Here is some review from me.
Great job anyway! I wish I didn't miss this builder option in the beginning so we wouldn't have that embarrassing message in the docs that Log4J appender cannot be extended. 😄

I'm still waiting for test to cover a new cool functionality.

Thank you very much!

[Scip88]

I have done the fix

[artembilan]

I think I'm good with this.
Thanks.

@garyrussell , any objections from your side?

[garyrussell]

@Scip88 Thanks for the contribution! Looking forward to more.

@artembilan Thanks for the review.