GH-723: Add AmqpResourceNotAvailableException #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#723 To avoid an `NPE` when connection returns `null` for the `createChannel()` in case of `channelMax` is reached, throw newly introduced `AmqpResourceNotAvailableException`. This exception can be used in the `RetryPolicy` to retry the original operation after some back-off - the channel permit may be released in between **Cherry-pick to 2.0.x and 1.7.x**
|
Travis failed |
garyrussell
reviewed
Apr 3, 2018
src/reference/asciidoc/amqp.adoc
Outdated
| @@ -377,6 +377,9 @@ Starting with _version 2.0.2_, the `RabbitTemplate` has a configuration option t | |||
| See <<separate-connection>> for more information. | |||
| The `ConnectionNameStrategy` for the publisher connection is the same as the primary strategy with `.publisher` appended to the result of calling the method. | |||
|
|
|||
| Starting with _version 1.7.7_, an `AmqpResourceNotAvailableException` is provided, which is thrown now when `SimpleConnection.createChannel()` can't create a `Channel` because a `channelMax` limit is reached. | |||
There was a problem hiding this comment.
s/can't create a Channel because a channelMax limit is reached./can't create a Channel, for example, because the channelMax limit is reached and there are no available channels in the cache./
* Fix `amqp.adoc` according PR comments
garyrussell
pushed a commit
that referenced
this pull request
Apr 3, 2018
* GH-723: Add AmqpResourceNotAvailableException Fixes #723 To avoid an `NPE` when connection returns `null` for the `createChannel()` in case of `channelMax` is reached, throw newly introduced `AmqpResourceNotAvailableException`. This exception can be used in the `RetryPolicy` to retry the original operation after some back-off - the channel permit may be released in between **Cherry-pick to 2.0.x and 1.7.x** * * Fix `AbstractConnectionFactoryTests` for proper mock * Fix `amqp.adoc` according PR comments
garyrussell
pushed a commit
that referenced
this pull request
Apr 3, 2018
* GH-723: Add AmqpResourceNotAvailableException Fixes #723 To avoid an `NPE` when connection returns `null` for the `createChannel()` in case of `channelMax` is reached, throw newly introduced `AmqpResourceNotAvailableException`. This exception can be used in the `RetryPolicy` to retry the original operation after some back-off - the channel permit may be released in between **Cherry-pick to 2.0.x and 1.7.x** * * Fix `AbstractConnectionFactoryTests` for proper mock * Fix `amqp.adoc` according PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #723
To avoid an
NPEwhen connection returnsnullfor thecreateChannel()in case ofchannelMaxis reached, throw newlyintroduced
AmqpResourceNotAvailableException.This exception can be used in the
RetryPolicyto retry the originaloperation after some back-off - the channel permit may be released in
between
Cherry-pick to 2.0.x and 1.7.x