GH-973: Higher order for RabbitListTestBootstrap #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#973 When we use `@EnableRabbit` and `@RabbitListenerTest` in the same configuration set, e.g. mixing real `@Configuration` and test one for `@RabbitListenerTest`, we may end up with the case when `@EnableRabbit` is processed before `@RabbitListenerTest`, so, `RabbitListenerTestHarness` bean is not going to appear in the application context. * Implement a `DeferredImportSelector` with an `@Order` for the `@EnableRabbit` as well as `RabbitListenerTest` giving higher order to the `RabbitListenerTestSelector`, so `RabbitListenerTestBootstrap` is processed and register its `RabbitListenerTestHarness` earlier, than it is done by the `RabbitBootstrapConfiguration` **Cherry-pick to 2.1.x**
* Add JavaDocs to new classes
garyrussell
pushed a commit
that referenced
this pull request
Apr 10, 2019
* GH-973: Higher order for RabbitListTestBootstrap Fixes #973 When we use `@EnableRabbit` and `@RabbitListenerTest` in the same configuration set, e.g. mixing real `@Configuration` and test one for `@RabbitListenerTest`, we may end up with the case when `@EnableRabbit` is processed before `@RabbitListenerTest`, so, `RabbitListenerTestHarness` bean is not going to appear in the application context. * Implement a `DeferredImportSelector` with an `@Order` for the `@EnableRabbit` as well as `RabbitListenerTest` giving higher order to the `RabbitListenerTestSelector`, so `RabbitListenerTestBootstrap` is processed and register its `RabbitListenerTestHarness` earlier, than it is done by the `RabbitBootstrapConfiguration` **Cherry-pick to 2.1.x** * * Fix Checkstyle * Add JavaDocs to new classes
|
Cherry-picked as c71ed1e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #973
When we use
@EnableRabbitand@RabbitListenerTestin the sameconfiguration set, e.g. mixing real
@Configurationand test one for@RabbitListenerTest, we may end up with the case when@EnableRabbitis processed before
@RabbitListenerTest, so,RabbitListenerTestHarnessbean is not going to appear in the application context.
DeferredImportSelectorwith an@Orderfor the@EnableRabbitas well asRabbitListenerTestgiving higher order tothe
RabbitListenerTestSelector, soRabbitListenerTestBootstrapisprocessed and register its
RabbitListenerTestHarnessearlier, than itis done by the
RabbitBootstrapConfigurationCherry-pick to 2.1.x