Skip to content

Commit

Permalink
Make sure custom finalName is ignored
Browse files Browse the repository at this point in the history
A read-only plugin parameter can still be set by the user which leads
to an invalid repackaged archive. This commit actually ignores the field
and uses the standard attribute instead.

Closes gh-16202
  • Loading branch information
snicoll committed Mar 29, 2019
1 parent 6ab942f commit 04aadcd
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,8 @@ private File getTargetFile() {
if (!this.outputDirectory.exists()) {
this.outputDirectory.mkdirs();
}
return new File(this.outputDirectory, this.finalName + classifier + "."
String finalName = this.project.getBuild().getFinalName();
return new File(this.outputDirectory, finalName + classifier + "."
+ this.project.getArtifact().getArtifactHandler().getExtension());
}

Expand Down

0 comments on commit 04aadcd

Please sign in to comment.