Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rationalize DefaultRestartInitializerTests #14927

Closed
mbhave opened this issue Oct 22, 2018 · 1 comment
Closed

Rationalize DefaultRestartInitializerTests #14927

mbhave opened this issue Oct 22, 2018 · 1 comment
Assignees
@mbhave
Labels
type: task A general task
Milestone
2.0.7

Comments

@mbhave
Copy link
Contributor

mbhave commented Oct 22, 2018

They use a MockRestartInitializer and this doesn't appear to be testing anything. Using a real one might work because thread.getStackTrace() returns and array with no elements and isSkippedStackElement doesn't kick in.
@mbhave mbhave added the type: task A general task label Oct 22, 2018
@mbhave mbhave added this to the 2.0.x milestone Oct 22, 2018
@mbhave
Copy link
Contributor Author

mbhave commented Oct 23, 2018

We should probably fix these before merging #14915 so that a test for that can be added.

@mbhave mbhave self-assigned this Oct 23, 2018
@mbhave mbhave modified the milestones: 2.0.x, 2.0.7 Oct 23, 2018
@mbhave mbhave closed this as completed in bc58d44 Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbhave mbhave

Labels
type: task A general task
Projects
None yet
Milestone
2.0.7
Development

No branches or pull requests
1 participant
@mbhave