Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip restarter not only for JUnit4 but also for JUnit5 #14915

Closed
wants to merge 1 commit into from

Conversation

michaldo
Copy link
Contributor

JUnit 5 test fails when starts application and devtools on classpath.

JUnit 4 pass because is treated as exception by DefaultRestartInitializer. It should also apply to JUnit 5

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 20, 2018
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 21, 2018
@philwebb philwebb added this to the 2.1.x milestone Oct 21, 2018
@mbhave mbhave modified the milestones: 2.1.x, 2.1.0 Oct 23, 2018
mbhave pushed a commit that referenced this pull request Oct 23, 2018
@mbhave mbhave closed this in 5f24af6 Oct 23, 2018
mbhave added a commit that referenced this pull request Oct 23, 2018
* gh-14915:
  Polish
  Skip restarter for JUnit5
@mbhave
Copy link
Contributor

mbhave commented Oct 23, 2018

@michaldo Thank you for your first pull request to Spring Boot. This is now on master along with this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants