Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jackson 2.12.1 #24415

Closed

Conversation

valfirst
Copy link
Contributor

@valfirst valfirst commented Dec 9, 2020

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 9, 2020
@wilkinsona wilkinsona added this to the 2.5.x milestone Dec 9, 2020
@wilkinsona wilkinsona added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 9, 2020
@philwebb philwebb added the for: merge-with-amendments Needs some changes when we merge label Dec 9, 2020
@philwebb
Copy link
Member

philwebb commented Dec 9, 2020

Interesting that some classes have been renamed. I wonder if we should try to tolerate older Jackson versions as well?

@dreis2211
Copy link
Contributor

@philwebb See FasterXML/jackson-databind#2715 for the reason behind the renaming.

@snicoll snicoll self-assigned this Dec 21, 2020
@snicoll snicoll modified the milestones: 2.5.x, 2.5.0-M1 Dec 21, 2020
snicoll pushed a commit that referenced this pull request Dec 21, 2020
snicoll added a commit that referenced this pull request Dec 21, 2020
Guard breaking change to PropertyNamingStrategies so that we tolerate
older Jackson versions.

See gh-24415
@snicoll snicoll closed this in 01cfb9e Dec 21, 2020
@snicoll
Copy link
Member

snicoll commented Dec 21, 2020

@valfirst thank you for making your first contribution to Spring Boot. I've polished to tolerate older Jackson versions.

@valfirst valfirst deleted the upgrade-to-jackson-2-12-0 branch December 21, 2020 15:30
@wilkinsona wilkinsona changed the title Upgrade to Jackson 2.12.0 Upgrade to Jackson 2.12.1 Jan 21, 2021
@wilkinsona
Copy link
Member

We subsequently upgraded to 2.12.1 (7b39cfb). I've retitled this PR so that the release notes are accurate and @valfirst is still credited for their contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: merge-with-amendments Needs some changes when we merge type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants