Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary semicolons from the Instant field of the DefaultRevisionMetadataUnitTests class #3670

Closed
wants to merge 1 commit into from
Closed

Remove unnecessary semicolons from the Instant field of the DefaultRevisionMetadataUnitTests class #3670

wants to merge 1 commit into from

Conversation

PgmJun
Copy link
Contributor

@PgmJun PgmJun commented Nov 8, 2024 •
edited
Loading

Closes #3669

class DefaultRevisionMetadataUnitTests {

	private static final Instant NOW = Instant.now();;

I found a semicolon in the Instant field of the DefaultRevisionMetadataUnitTests class that is being used unnecessarily.

class DefaultRevisionMetadataUnitTests {

	private static final Instant NOW = Instant.now();

So I tried to remove one unnecessary semicolon.

@PgmJun
Remove the double semicolon of the class field.
fac69f8 
Remove unnecessary semicolons from the Instant field of the DefaultRevisionMetadataUnitTests class.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 8, 2024
@PgmJun PgmJun changed the title Remove the double semicolon of the class field. Remove unnecessary semicolons from the Instant field of the DefaultRevisionMetadataUnitTests class Nov 8, 2024
@mp911de mp911de self-assigned this Nov 11, 2024
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 11, 2024
mp911de pushed a commit that referenced this pull request Nov 14, 2024
@PgmJun @mp911de
Polishing.
c9aa45e 
Remove unnecessary semicolons DefaultRevisionMetadataUnitTests class.

Original pull request: #3670
Closes #3669
mp911de pushed a commit that referenced this pull request Nov 14, 2024
@PgmJun @mp911de
Polishing.
5fa723c 
Remove unnecessary semicolons DefaultRevisionMetadataUnitTests class.

Original pull request: #3670
Closes #3669
mp911de pushed a commit that referenced this pull request Nov 14, 2024
@PgmJun @mp911de
Polishing.
1db98f5 
Remove unnecessary semicolons DefaultRevisionMetadataUnitTests class.

Original pull request: #3670
Closes #3669
@mp911de mp911de added this to the 3.2.12 (2023.1.12) milestone Nov 14, 2024
@mp911de
Copy link
Member

mp911de commented Nov 14, 2024

Thank you for your contribution. That's merged and backported now.

@mp911de mp911de closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: task A general task
Projects
None yet
Milestone
3.2.12 (2023.1.12)
Development

Successfully merging this pull request may close these issues.

It seems that the double semicolon in the Instant class member in DefaultRevisionMetadataUnitTests is a typo.
3 participants
@PgmJun @mp911de @spring-projects-issues