DATAJPA-1506 - Fix alias detection for native query. #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no alias is specified in a native query that does not contain a WHERE clause right after the FROM clause, this is now correctly detected.
odrotbohm
pushed a commit
that referenced
this pull request
May 9, 2019
When no alias is specified in a native query that does not contain a WHERE clause right after the FROM clause, this is now correctly detected. Original pull request: #379.
odrotbohm
added a commit
that referenced
this pull request
May 9, 2019
Extracted new tests into separate test method. Switch to AssertJ assertions. Original pull request: #379.
odrotbohm
pushed a commit
that referenced
this pull request
May 9, 2019
When no alias is specified in a native query that does not contain a WHERE clause right after the FROM clause, this is now correctly detected. Original pull request: #379.
odrotbohm
added a commit
that referenced
this pull request
May 9, 2019
Extracted new tests into separate test method. Switch to AssertJ assertions. Original pull request: #379.
odrotbohm
pushed a commit
that referenced
this pull request
May 9, 2019
When no alias is specified in a native query that does not contain a WHERE clause right after the FROM clause, this is now correctly detected. Original pull request: #379.
odrotbohm
added a commit
that referenced
this pull request
May 9, 2019
Extracted new tests into separate test method. Original pull request: #379.
odrotbohm
pushed a commit
that referenced
this pull request
May 9, 2019
When no alias is specified in a native query that does not contain a WHERE clause right after the FROM clause, this is now correctly detected. Original pull request: #379.
odrotbohm
added a commit
that referenced
this pull request
May 9, 2019
Extracted new tests into separate test method. Switch to AssertJ assertions. Original pull request: #379.
odrotbohm
added a commit
that referenced
this pull request
May 9, 2019
Extracted new tests into separate test method. Switch to AssertJ assertions. Original pull request: #379.
odrotbohm
added a commit
that referenced
this pull request
May 9, 2019
Extracted new tests into separate test method. Original pull request: #379.
odrotbohm
added a commit
that referenced
this pull request
May 9, 2019
Extracted new tests into separate test method. Switch to AssertJ assertions. Original pull request: #379.
odrotbohm
added a commit
that referenced
this pull request
May 9, 2019
Extracted new tests into separate test method. Switch to AssertJ assertions. Original pull request: #379.
|
Merged, polished and backported. Thanks! |
stsypanov
pushed a commit
to stsypanov/spring-data-jpa
that referenced
this pull request
Dec 13, 2019
When no alias is specified in a native query that does not contain a WHERE clause right after the FROM clause, this is now correctly detected. Original pull request: spring-projects#379.
stsypanov
pushed a commit
to stsypanov/spring-data-jpa
that referenced
this pull request
Dec 13, 2019
Extracted new tests into separate test method. Switch to AssertJ assertions. Original pull request: spring-projects#379.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no alias is specified in a native query that does not contain a WHERE clause right after the FROM clause, this is now correctly detected.
Link to Jira Ticket
I have added support for the
ORDER BYandGROUP BYclauses because these are fairly common and available in almost every SQL flavor. Should I consider to add more possible clauses likeLIMIT?