Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/3.1.x/3055 #3541

Closed
wants to merge 3 commits into from
Closed

Issue/3.1.x/3055 #3541

wants to merge 3 commits into from

Conversation

christophstrobl
Copy link
Member

Update count vs. estimatedCount documentation and allow access to mongoDatabaseFactory used in ReactiveMongoTemplate so users can subclass the template and override doCount while being able to check for the presence of an ongoing transaction using ReactiveMongoDatabaseUtils.isTransactionActive(getDatabaseFactory()).

By offering a getter method for the ReactiveMongoDatabaseFactory users subclassing ReactiveMongoTemplate could evaluate the current transaction state via ReactiveMongoDatabaseUtils.isTransactionActive(getDatabaseFactory()).
This change also aligns the reactive and imperative template implementation in that regard.

Closes #3540
@christophstrobl christophstrobl added type: documentation A documentation update type: task A general task labels Jan 21, 2021
mp911de pushed a commit that referenced this pull request Feb 2, 2021
mp911de pushed a commit that referenced this pull request Feb 2, 2021
By offering a getter method for the ReactiveMongoDatabaseFactory users subclassing ReactiveMongoTemplate could evaluate the current transaction state via ReactiveMongoDatabaseUtils.isTransactionActive(getDatabaseFactory()).
This change also aligns the reactive and imperative template implementation in that regard.

Closes #3540
Original pull request: #3541.
mp911de pushed a commit that referenced this pull request Feb 2, 2021
mp911de pushed a commit that referenced this pull request Feb 2, 2021
By offering a getter method for the ReactiveMongoDatabaseFactory users subclassing ReactiveMongoTemplate could evaluate the current transaction state via ReactiveMongoDatabaseUtils.isTransactionActive(getDatabaseFactory()).
This change also aligns the reactive and imperative template implementation in that regard.

Closes #3540
Original pull request: #3541.
@mp911de
Copy link
Member

mp911de commented Feb 2, 2021

That's merged and backported now.

@mp911de mp911de closed this Feb 2, 2021
@mp911de mp911de added this to the 3.1.4 (2020.0.4) milestone Feb 2, 2021
@mp911de mp911de deleted the issue/3.1.x/3055 branch February 2, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update type: task A general task
Projects
None yet
2 participants