Introduce ConversionContext and clean up MappingMongoConverter #3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move static methods around. Revisit nullability annotations. Extract conversion service call into own method.
Reintroduce deprecated API. Make conversion entrypoint methods protected so that they can be overridden. Tweak Javadoc.
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
commented
Mar 3, 2021
| * @param key must not be {@literal null}. | ||
| * @param value can be {@literal null}. | ||
| * @return {@literal true} if (key/value pair) is present. | ||
| * @since 2.5 |
There was a problem hiding this comment.
This should be @since 3.2
mp911de
commented
Mar 3, 2021
| * Remove {@code _id : null} from the given {@link Bson} if present. | ||
| * | ||
| * @param bson must not be {@literal null}. | ||
| * @since 2.5 |
There was a problem hiding this comment.
This should be @since 3.2
christophstrobl
pushed a commit
that referenced
this pull request
Mar 3, 2021
Introduce a ConversionContext used during the mapping process to carry forward required information. ConversionContext serves as entrpoint for recursive (read) conversion of documents, lists, maps, and simple values. The actual decision which converter strategy to apply is now encapsulated by ConversionContext.convert(…) which removes strategy duplications from the actual conversion methods. Also, converter methods for documents, maps, lists, … are now protected for easier customization by subclasses. Closes #3571 Original Pull Request: #3575
christophstrobl
added a commit
that referenced
this pull request
Mar 3, 2021
Also remove MapUtils and blend new methods into the existing BsonUtils. Original Pull Request: #3575
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConversionContextserves as entrpoint for recursive (read) conversion of documents, lists, maps, and simple values. The actual decision which converter strategy to apply is now encapsulated byConversionContext.convert(…)which removes strategy duplications from the actual conversion methods.Also, converter methods for documents, maps, lists, … are now
protectedfor easier customization by subclasses.Closes #3571