Revise RedisKeyValueAdapter to support lifecycle #2959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedisKeyValueAdapter is now a lifecycle bean participating in Spring's SmartLifecycle support. Sticking to Lifecycle aligns with lifecycle support in RedisConnectionFactory where connections are stopped upon shutdown. Previously, RedisKeyValueAdapter stopped connections upon destroy() causing a delayed shutdown behavior that was out of sync with its RedisConnectionFactory.
Reorder methods, reformat code.
christophstrobl
pushed a commit
that referenced
this pull request
Aug 8, 2024
RedisKeyValueAdapter is now a lifecycle bean participating in Spring's SmartLifecycle support. Sticking to Lifecycle aligns with lifecycle support in RedisConnectionFactory where connections are stopped upon shutdown. Previously, RedisKeyValueAdapter stopped connections upon destroy() causing a delayed shutdown behavior that was out of sync with its RedisConnectionFactory. Closes: #2957 Original Pull Request: #2959
christophstrobl
pushed a commit
that referenced
this pull request
Aug 8, 2024
Reorder methods, reformat code. Original Pull Request: #2959
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RedisKeyValueAdapteris now a lifecycle bean participating in Spring'sSmartLifecyclesupport. Sticking to Lifecycle aligns with lifecycle support inRedisConnectionFactorywhere connections are stopped upon shutdown.Previously,
RedisKeyValueAdapterstopped connections upondestroy()causing a delayed shutdown behavior that was out of sync with itsRedisConnectionFactory.Closes #2957