Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small documentation issues #295

Closed

Conversation

florianluediger
Copy link
Contributor

Related Jira tickets are: DATAREST-810 and DATAREST-811

@florianluediger
Copy link
Contributor Author

@olivergierke Have you looked into this? These are just some minor changes.

odrotbohm pushed a commit that referenced this pull request Jul 4, 2018
Original pull request: #295.

$ Conflicts:
$	spring-data-rest-webmvc/src/main/java/org/springframework/data/rest/webmvc/RepositoryEntityController.java
odrotbohm pushed a commit that referenced this pull request Jul 4, 2018
odrotbohm added a commit that referenced this pull request Jul 4, 2018
…culation.

We now explain in detail which @Version annotation to use as it depends on which store is backing the entity.

Original pull request: #295.
odrotbohm pushed a commit that referenced this pull request Jul 4, 2018
Original pull request: #295.

$ Conflicts:
$	spring-data-rest-webmvc/src/main/java/org/springframework/data/rest/webmvc/RepositoryEntityController.java
odrotbohm pushed a commit that referenced this pull request Jul 4, 2018
odrotbohm added a commit that referenced this pull request Jul 4, 2018
…culation.

We now explain in detail which @Version annotation to use as it depends on which store is backing the entity.

Original pull request: #295.
odrotbohm pushed a commit that referenced this pull request Jul 4, 2018
odrotbohm pushed a commit that referenced this pull request Jul 4, 2018
odrotbohm added a commit that referenced this pull request Jul 4, 2018
…culation.

We now explain in detail which @Version annotation to use as it depends on which store is backing the entity.

Original pull request: #295.
@odrotbohm
Copy link
Member

Thanks for your patience, Florian. I guess it got lost as we don't too closely monitor PRs themselves unless the authors don't actively trigger the "Submit Review…" action in the "Workflow" menu.

I've applied your changes and backported them to Kay and Ingalls. I've tweaked the change regarding the @Version annotation as Willie's analysis wasn't entirely correct. See my comment on DATAREST-811.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants