Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross reference additional Aware interfaces from BeanFactory Javadoc #27034

Closed
wants to merge 1 commit into from
Closed

Cross reference additional Aware interfaces from BeanFactory Javadoc #27034

wants to merge 1 commit into from

Conversation

Beca-se
Copy link
Contributor

@Beca-se Beca-se commented Jun 8, 2021

Add BeanFactory comment

@Beca-se
Add BeanFactory comment
88b6ee6 
Add BeanFactory comment
@pivotal-cla
Copy link

@Beca-se Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@Beca-se Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 8, 2021
@snicoll
Copy link
Member

snicoll commented Jun 8, 2021

@Beca-se did you mean to open this PR? The title doesn't match the commit.

@Beca-se
Copy link
Contributor Author

Beca-se commented Jun 8, 2021

@Beca-se did you mean to open this PR? The title doesn't match the commit.

@snicoll This is my PR. Can you help me to updated this then open this PR.

@snicoll
Copy link
Member

snicoll commented Jun 8, 2021

Sorry for some reasons I read those as imports. More coffee needed here, I guess.

Can you share why you think those two @see references are warranted?

@snicoll snicoll added in: core Issues in core modules (aop, beans, core, context, expression) status: waiting-for-feedback We need additional information before we can continue labels Jun 8, 2021
@Beca-se
Copy link
Contributor Author

Beca-se commented Jun 8, 2021

Sorry for some reasons I read those as imports. More coffee needed here, I guess.

Can you share why you think those two @see references are warranted?

image

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jun 8, 2021
@sbrannen sbrannen changed the title Add BeanFactory comment Cross reference additional Aware interfaces from BeanFactory Javadoc Jun 8, 2021
@sbrannen sbrannen added type: task A general task and removed status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 8, 2021
@sbrannen sbrannen self-assigned this Jun 8, 2021
@sbrannen sbrannen added this to the 5.3.8 milestone Jun 8, 2021
@sbrannen
Copy link
Member

sbrannen commented Jun 8, 2021

Can you share why you think those two @see references are warranted?

The class-level Javadoc for BeanFactory contains a section that lists the "full set of initialization methods and their standard order". These two methods are listed there but are not cross referenced with @see tags like the others in the list.

@sbrannen sbrannen closed this in 3966071 Jun 8, 2021
sbrannen added a commit that referenced this pull request Jun 8, 2021
@sbrannen
Polish contribution
29fa9c1 
See gh-27034
@sbrannen
Copy link
Member

sbrannen commented Jun 8, 2021

This has been merged into main.

Thanks

lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
@Beca-se @lxbzmy
Cross-ref additional *Aware APIs in BeanFactory Javadoc
2d60e73 
Closes spring-projectsgh-27034
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
@sbrannen @lxbzmy
Polish contribution
025dc0d 
See spring-projectsgh-27034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Projects
None yet
Milestone
5.3.8
Development

Successfully merging this pull request may close these issues.
5 participants
@Beca-se @pivotal-cla @snicoll @sbrannen @spring-projects-issues