Add default implementations to RetryListener
#326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
requested changes
Nov 28, 2022
There was a problem hiding this comment.
Please, add your name to the @author list of all the affected classes.
Also update their copyright to the current 2022.
There is also a mentioning of RetryListenerSupport in the README.
Consider, please, revise that docs respectively.
(Not sure if we should mention its deprecation: just remove will be enough)
src/test/java/org/springframework/retry/listener/RetryListenerSupportTests.java
Show resolved
Hide resolved
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
since="2.0.1", forRemoval=true ?
|
@artembilan Thanks for the feedback! The year in the headers is already 2022 in almost all affected classes. But I've added the |
|
thank you for contribution; looking forward for more! |
artembilan
added a commit
to spring-projects/spring-integration
that referenced
this pull request
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Spring Retry 2.0.0, the baseline was lifted from Java 6 to Java 17, which allows to now use default implementations in interfaces.
The only purpose of
RetryListenerSupportis to provide default implementations forRetryListener. As such support implementations are no longer required, this PR deprecatesRetryListenerSupportand adds its default implementations toRetryListener.