Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Deprecated Usages of RemoteJWKSet #16537

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Remove Deprecated Usages of RemoteJWKSet #16537

merged 3 commits into from
Feb 5, 2025

Conversation

kwondh5217
Copy link
Contributor

Closes gh-16251

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 4, 2025
@jzheaux jzheaux force-pushed the gh-16251 branch 3 times, most recently from dc57d0b to 36ff8e6 Compare February 5, 2025 01:17
@jzheaux jzheaux self-assigned this Feb 5, 2025
@jzheaux jzheaux added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 5, 2025
@jzheaux jzheaux added this to the 6.5.0-M2 milestone Feb 5, 2025
@jzheaux jzheaux merged commit 11113ad into spring-projects:main Feb 5, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Feb 5, 2025 •
edited
Loading

Thanks, @kwondh5217! This is now merged into main.

Note that I added a polish to update the unit tests to be more resilient to these kinds of changes and not rely as much on implementation details: 20b6fee

I simplified the logic in NimbusJwtDecoder somewhat by changing to implement JWKSetSource, a new Nimbus interface. Also, I removed the need for the extra JWK Set call (thank you for noting that in the update to JwtDecodersTests). Now that is unnecssary: 457f4db

@kwondh5217
Copy link
Contributor Author

Thanks, @jzheaux ! 🥳

@kwondh5217 kwondh5217 deleted the gh-16251 branch February 5, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
6.5.0-M2
Development

Successfully merging this pull request may close these issues.

Remove Deprecated Usages of RemoteJWKSet
3 participants
@kwondh5217 @jzheaux @spring-projects-issues