Eliminate afterEvaluate #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to update the Kotlin version as the project wouldn't compile (not JDK11 nor JDK17) |
added 2 commits
June 6, 2023 14:02
MartinAhrer
force-pushed
the
fix/afterEvaluate
branch
from
acecbce to
f54749d
Compare
|
Agreed that use of afterEvaluate should be avoided, and that it has caused numerous issues. Can this be merged, or at least a comment on why not? |
|
Will be merged soon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request eliminates the usage of afterEvaluate that is causing all sorts of side-effects especially with implementing convention plugins configuring defaults