Make plugin work under Gradle 7 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle 7 requires that task properties be annotated to indicate how they should be treated when calculating what artifacts need to be rebuilt. One of the methods in the gradle-processes plugin was missing an annotation, which caused the plugin to bomb out under Gradle 7. Fix it by subclassing the task in question and annotating the method.
|
There's an open issue #36 to replace the gradle-processes plugin entirely, but while that change is being considered, this one can serve as a stopgap to at least keep the plugin usable now that Gradle 7 is officially released. |
|
thanks for making this PR. I had created issue #47 before i saw it. Hope it gets merged soon! |
|
Thank you for your initiative and contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle 7 requires that task properties be annotated to indicate how they should be
treated when calculating what artifacts need to be rebuilt. One of the methods in
the gradle-processes plugin was missing an annotation, which caused the plugin to
bomb out under Gradle 7.
Fix it by subclassing the task in question and annotating the method.