Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce customBootRun property for customizing runtime parameter for Spring application #78

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

litols
Copy link
Contributor

@litols litols commented Jun 12, 2022

Motivation:

resolve #75

Modification:

introduce customBootRun. This is propety-customizer for bootRun which is used in this plugin.
the users can specify custom parameter like following:

openApi {
    customBootRun {
        args = ["--spring.profiles.active=different-url"] 
    }
}

If the parameter is not specified by user, this plugin uses the parameter specified in bootRun in Spring Boot Gradle Plugin instead.
As a result, we can satisfy the following requirement this plugin users.

  • the case that the users need specifing static properties to generate openapi schema(by the way, this includes me!)
  • the case that the users need to try this plugin quickly

Notes:

  • springdoc-openapi-gradle-plugin 1.3.4 had removed forkProperties. it is breaking changes for the users... also the user needs to migrate to customBootRun to upgrade this plugin continuously, so I recommend that you might want to release this changes as version 1.4.0.

@litols
Copy link
Contributor Author

litols commented Jul 4, 2022

@bnasslahsen sorry for mention by name directly, please take a look this PR if you have a time?

@thattolleyguy
Copy link

Would love to see this merged and released

@juliaisnotavailable
Copy link

Would also love to see this released. The previous release 1.3.4 introduced a breaking change with regards to the forkProperties config. This would be a very welcome update.

@bnasslahsen bnasslahsen merged commit d37f32f into springdoc:master Aug 6, 2022
@bnasslahsen
Copy link
Contributor

Thank you @litols for your contribution to the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fork properties not found
4 participants