Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes khttp #92

Merged
merged 3 commits into from
Nov 12, 2022
Merged

Removes khttp #92

merged 3 commits into from
Nov 12, 2022

Conversation

raviu
Copy link
Contributor

@raviu raviu commented Nov 8, 2022 •
edited
Loading

It seems we're currently only using khttp for something pretty simple.
Would we be able to replace it with something like this? Not sure if there were plans to use khttp for something else.

Potentially for #91

@raviu raviu marked this pull request as ready for review November 8, 2022 05:38
@bclabs-kylian
Copy link

Wow, @raviu you are awesome. Hope this get merged soon.

@kevinmcp123 kevinmcp123 mentioned this pull request Nov 8, 2022
Closed
@Hemantkumar-Chigadani
Copy link

Hemantkumar-Chigadani commented Nov 8, 2022 •
edited
Loading

Nice, good to get this moving, thanks alot.

@EdgarGhazaryan
Copy link

Thank you @raviu.
Please also don't forget to update plugin version with this fix included.

@cogito-omkar
Copy link

cc: @bnasslahsen can you look into this please? it is very important for many!

@Amar97
Copy link

Amar97 commented Nov 8, 2022

@raviu thanks for the quick fix, hope this gets merged soon

@raymondasbreuk
Copy link

When can this be merged? Hope this gets merged soon

@nathansandi
Copy link

When this gonna be merged? :) Also fighting problems with this

raviu and others added 2 commits November 9, 2022 07:41
@raviu @PascalPensa
Update src/main/kotlin/org/springdoc/openapi/gradle/plugin/OpenApiGen…
ffcd50e 
…eratorTask.kt


Shadowing of local variables should generally be avoided

Co-authored-by: PascalPensa <[email protected]>
@raviu @PascalPensa
Update src/main/kotlin/org/springdoc/openapi/gradle/plugin/OpenApiGen…
9a7db22 
…eratorTask.kt


Shadowing of local variables should generally be avoided

Co-authored-by: PascalPensa <[email protected]>
@sloppylopez
Copy link

Hello, do we have an stimation on when this will get merged?

@bnasslahsen
Copy link
Contributor

By the end of this week hopefully!

@raviu
Copy link
Contributor Author

raviu commented Nov 9, 2022

The urgency of this has dropped now that the read only jcenter/bintray repos are back. This situation could happen again though. Worthy checking options over at khttp as an alternative.

@kamilchmiel
Copy link

kamilchmiel commented Nov 10, 2022 •
edited
Loading

Khttp is not available on https://repo.maven.apache.org/maven2/ (it used to be until recently), so it would be nice to release the change.

This dependency doesn't seem to be needed (you provided a clear and simple replacement), and there are CVE-2022-24329, and CVE-2020-29582 associated with it, so it's an unnecessary burden.

@bnasslahsen bnasslahsen merged commit 0bd2f18 into springdoc:master Nov 12, 2022
@jiang95-dev jiang95-dev mentioned this pull request Jul 16, 2024
Merged
17 tasks
jiang95-dev added a commit to linkedin/openhouse that referenced this pull request Jul 17, 2024
@jiang95-dev
Fix github build failure (#137)
27a8a07 
## Summary

The build failed because of missing `khttp` library that is required by
`springdoc-openapi` plugin. This library has been removed from maven2
repo from 2022, so not sure why the previous build succeeded (maybe
github caches some gradle libraries). The `springdoc-openapi` plugin has
removed the usage of `khttp` too since `1.5.0`. I'm upgrading the
version to `1.6.0` which is the latest that gradle 6 supports.

More details in this issue:
springdoc/springdoc-openapi-gradle-plugin#92.

## Changes

- [ ] Client-facing API Changes
- [ ] Internal API Changes
- [x] Bug Fixes
- [ ] New Features
- [ ] Performance Improvements
- [ ] Code Style
- [ ] Refactoring
- [ ] Documentation
- [ ] Tests

For all the boxes checked, please include additional details of the
changes made in this pull request.

## Testing Done
<!--- Check any relevant boxes with "x" -->

- [ ] Manually Tested on local docker setup. Please include commands
ran, and their output.
- [ ] Added new tests for the changes made.
- [ ] Updated existing tests to reflect the changes made.
- [x] No tests added or updated. Please explain why. If unsure, please
feel free to ask for help.
- [ ] Some other form of testing like staging or soak time in
production. Please explain.

For all the boxes checked, include a detailed description of the testing
done for the changes made in this pull request.

# Additional Information

- [ ] Breaking Changes
- [ ] Deprecations
- [ ] Large PR broken into smaller PRs, and PR plan linked in the
description.

For all the boxes checked, include additional details of the changes
made in this pull request.
kmcclenn pushed a commit to kmcclenn/openhouse that referenced this pull request Jul 17, 2024
@jiang95-dev @kmcclenn
Fix github build failure (linkedin#137)
ef0d92e 
## Summary

The build failed because of missing `khttp` library that is required by
`springdoc-openapi` plugin. This library has been removed from maven2
repo from 2022, so not sure why the previous build succeeded (maybe
github caches some gradle libraries). The `springdoc-openapi` plugin has
removed the usage of `khttp` too since `1.5.0`. I'm upgrading the
version to `1.6.0` which is the latest that gradle 6 supports.

More details in this issue:
springdoc/springdoc-openapi-gradle-plugin#92.

## Changes

- [ ] Client-facing API Changes
- [ ] Internal API Changes
- [x] Bug Fixes
- [ ] New Features
- [ ] Performance Improvements
- [ ] Code Style
- [ ] Refactoring
- [ ] Documentation
- [ ] Tests

For all the boxes checked, please include additional details of the
changes made in this pull request.

## Testing Done
<!--- Check any relevant boxes with "x" -->

- [ ] Manually Tested on local docker setup. Please include commands
ran, and their output.
- [ ] Added new tests for the changes made.
- [ ] Updated existing tests to reflect the changes made.
- [x] No tests added or updated. Please explain why. If unsure, please
feel free to ask for help.
- [ ] Some other form of testing like staging or soak time in
production. Please explain.

For all the boxes checked, include a detailed description of the testing
done for the changes made in this pull request.

# Additional Information

- [ ] Breaking Changes
- [ ] Deprecations
- [ ] Large PR broken into smaller PRs, and PR plan linked in the
description.

For all the boxes checked, include additional details of the changes
made in this pull request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalPensa PascalPensa PascalPensa left review comments

@kevinmcp123 kevinmcp123 kevinmcp123 approved these changes

@isasouza-meli isasouza-meli isasouza-meli approved these changes

@rkorpalski-meli rkorpalski-meli rkorpalski-meli approved these changes

@domnikl domnikl domnikl approved these changes

@raymondasbreuk raymondasbreuk raymondasbreuk approved these changes

@raymieloman raymieloman raymieloman approved these changes

@wevertonbruno wevertonbruno wevertonbruno approved these changes

@dcasanovaf dcasanovaf dcasanovaf approved these changes

@steindekker steindekker steindekker approved these changes

@marcuscraske marcuscraske marcuscraske approved these changes

@iBianquini iBianquini iBianquini approved these changes

@koenbeckers koenbeckers koenbeckers approved these changes

@Amar97 Amar97 Amar97 approved these changes

@nathansandi nathansandi nathansandi approved these changes

@EdgarGhazaryan EdgarGhazaryan EdgarGhazaryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.