Fix build error due to invalid version of tests module #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: johnniang <[email protected]>
|
Totally agree 76d3dd6. |
JohnNiang
commented
Jul 31, 2022
| @@ -79,6 +79,7 @@ | |||
| <module>springdoc-openapi-starter-webflux-api</module> | |||
| <module>springdoc-openapi-starter-webmvc-ui</module> | |||
| <module>springdoc-openapi-starter-webflux-ui</module> | |||
| <module>springdoc-openapi-tests</module> | |||
There was a problem hiding this comment.
Hi, @bnasslahsen , please note the new module springdoc-openapi-tests here. After adding it, 3eddb9d and 7226564 will update the version automatically instead of updating manually.
If we care about the deployment for the module springdoc-openapi-tests, don't forget to configure the plugin maven-deploy-plugin at springdoc-openapi-tests/pom.xml:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-deploy-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
There was a problem hiding this comment.
Thank you for your hint. For springdoc-openapi-tests it won't be necessary to keep deploying this module.
bnasslahsen
pushed a commit
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of this PR
/kind bug
What this PR does / Why we need it
springdoc-openapi-testsas a submodule. After doing this, the versions in submodules will be automatically updated when the next release is made. Please refer to 9528d8f.