-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line height reduction #856
base: main
Are you sure you want to change the base?
Changes from 17 commits
ce8a897
0f3e281
4dc9d88
5e448ae
09fa2c2
b817b1a
ad6cb4a
d426c1e
058dd79
04477a5
1879c7a
51dd5ec
3d4dc15
6735b54
d4e6c1a
8b80bc6
ea4fa24
11f0eb1
68bb851
9400543
bfc6f08
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
|
||
// Do not edit directly | ||
// Generated on Fri, 21 Oct 2022 11:11:43 GMT | ||
// Generated on Mon, 09 Jan 2023 13:28:25 GMT | ||
|
||
$t-background-page: #f8f8f8 !default; | ||
$t-background-container: #ffffff !default; | ||
$t-background-container-inverted: #222222 !default; | ||
$t-background-page: #f8f8f8; | ||
$t-background-container: #ffffff; | ||
$t-background-container-inverted: #222222; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
|
||
// Do not edit directly | ||
// Generated on Fri, 21 Oct 2022 11:11:43 GMT | ||
// Generated on Mon, 09 Jan 2023 13:28:25 GMT | ||
|
||
$t-border-color-primary: #222222 !default; | ||
$t-border-color-input: #999999 !default; | ||
$t-border-color-button: #01324b !default; | ||
$t-border-color-indent: #dadada !default; | ||
$t-border-radius-50: 2px !default; | ||
$t-border-radius-100: 4px !default; | ||
$t-border-width-25: 1px !default; | ||
$t-border-width-50: 2px !default; | ||
$t-border-width-100: 4px !default; | ||
$t-border-width-200: 8px !default; | ||
$t-border-color-primary: #222222; | ||
$t-border-color-input: #999999; | ||
$t-border-color-button: #01324b; | ||
$t-border-color-indent: #dadada; | ||
$t-border-radius-50: 2px; | ||
$t-border-radius-100: 4px; | ||
$t-border-width-25: 1px; | ||
$t-border-width-50: 2px; | ||
$t-border-width-100: 4px; | ||
$t-border-width-200: 8px; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
|
||
// Do not edit directly | ||
// Generated on Fri, 21 Oct 2022 11:11:43 GMT | ||
// Generated on Mon, 09 Jan 2023 13:28:25 GMT | ||
|
||
$t-button-background-primary-resting: #01324b !default; | ||
$t-button-background-primary-hover: #ffffff !default; | ||
$t-button-background-secondary-resting: #ffffff !default; | ||
$t-button-background-secondary-hover: #01324b !default; | ||
$t-button-background-primary-resting: #01324b; | ||
$t-button-background-primary-hover: #ffffff; | ||
$t-button-background-secondary-resting: #ffffff; | ||
$t-button-background-secondary-hover: #01324b; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
|
||
// Do not edit directly | ||
// Generated on Fri, 21 Oct 2022 11:11:43 GMT | ||
// Generated on Mon, 09 Jan 2023 13:28:25 GMT | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There aren't actually any changes to this file, I think we need a way to not generate this line when the file doesn't change as it's extremely noisy There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In fact is there any need for this "Generated on" message? Github shows the last changed date There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Agreed, I have a task to look at seeing how we can 'test' what has changed and get Style Dictionary to act accordingly. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I guess not - as the 'do not edit directly' message is there.
We're assuming folks would check this‽ Although tools like VSCode are quite adept at showing this information (even line-by-line). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think what we need is these files to be auto-generated as part of the package management, then there is no need fo anyone to check anything There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I'd love some form of automation for this so it's not "yet another 🤞🏼 the single release 🤞🏼 |
||
|
||
$t-gap-0: 0; | ||
$t-gap-100: .25rem; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
|
||
// Do not edit directly | ||
// Generated on Fri, 21 Oct 2022 11:11:43 GMT | ||
// Generated on Mon, 09 Jan 2023 13:28:25 GMT | ||
|
||
$t-icon-checkbox-checked-stroke: #ffffff !default; | ||
$t-icon-checkbox-checked-fill: #01324b !default; | ||
$t-icon-select-stroke: #000000 !default; | ||
$t-icon-checkbox-checked-stroke: #ffffff; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A lot of file seem to have this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's related, when Sass meets two Me adding Sadly I had added |
||
$t-icon-checkbox-checked-fill: #01324b; | ||
$t-icon-select-stroke: #000000; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
|
||
// Do not edit directly | ||
// Generated on Fri, 21 Oct 2022 11:11:43 GMT | ||
// Generated on Mon, 09 Jan 2023 13:28:25 GMT | ||
|
||
$t-link-color: #025e8d !default; | ||
$t-link-hover: #01324b !default; | ||
$t-link-visited: #01324b !default; | ||
$t-link-focus: #0088cc !default; | ||
$t-link-color: #025e8d; | ||
$t-link-hover: #01324b; | ||
$t-link-visited: #01324b; | ||
$t-link-focus: #0088cc; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,60 +1,60 @@ | ||
|
||
// Do not edit directly | ||
// Generated on Fri, 21 Oct 2022 11:11:43 GMT | ||
// Generated on Mon, 09 Jan 2023 13:28:25 GMT | ||
|
||
$t-margin-0: 0 !default; | ||
$t-margin-100: .25rem !default; | ||
$t-margin-200: .5rem !default; | ||
$t-margin-400: 1rem !default; | ||
$t-margin-600: 1.5rem !default; | ||
$t-margin-800: 2rem !default; | ||
$t-margin-1200: 3rem !default; | ||
$t-margin-1600: 4rem !default; | ||
$t-margin-inline-0: 0 !default; | ||
$t-margin-inline-100: .25rem !default; | ||
$t-margin-inline-200: .5rem !default; | ||
$t-margin-inline-400: 1rem !default; | ||
$t-margin-inline-600: 1.5rem !default; | ||
$t-margin-inline-800: 2rem !default; | ||
$t-margin-inline-1200: 3rem !default; | ||
$t-margin-inline-1600: 4rem !default; | ||
$t-margin-inline-start-0: 0 !default; | ||
$t-margin-inline-start-100: .25rem !default; | ||
$t-margin-inline-start-200: .5rem !default; | ||
$t-margin-inline-start-400: 1rem !default; | ||
$t-margin-inline-start-600: 1.5rem !default; | ||
$t-margin-inline-start-800: 2rem !default; | ||
$t-margin-inline-start-1200: 3rem !default; | ||
$t-margin-inline-start-1600: 4rem !default; | ||
$t-margin-inline-end-0: 0 !default; | ||
$t-margin-inline-end-100: .25rem !default; | ||
$t-margin-inline-end-200: .5rem !default; | ||
$t-margin-inline-end-400: 1rem !default; | ||
$t-margin-inline-end-600: 1.5rem !default; | ||
$t-margin-inline-end-800: 2rem !default; | ||
$t-margin-inline-end-1200: 3rem !default; | ||
$t-margin-inline-end-1600: 4rem !default; | ||
$t-margin-block-0: 0 !default; | ||
$t-margin-block-100: .25rem !default; | ||
$t-margin-block-200: .5rem !default; | ||
$t-margin-block-400: 1rem !default; | ||
$t-margin-block-600: 1.5rem !default; | ||
$t-margin-block-800: 2rem !default; | ||
$t-margin-block-1200: 3rem !default; | ||
$t-margin-block-1600: 4rem !default; | ||
$t-margin-block-start-0: 0 !default; | ||
$t-margin-block-start-100: .25rem !default; | ||
$t-margin-block-start-200: .5rem !default; | ||
$t-margin-block-start-400: 1rem !default; | ||
$t-margin-block-start-600: 1.5rem !default; | ||
$t-margin-block-start-800: 2rem !default; | ||
$t-margin-block-start-1200: 3rem !default; | ||
$t-margin-block-start-1600: 4rem !default; | ||
$t-margin-block-end-0: 0 !default; | ||
$t-margin-block-end-100: .25rem !default; | ||
$t-margin-block-end-200: .5rem !default; | ||
$t-margin-block-end-400: 1rem !default; | ||
$t-margin-block-end-600: 1.5rem !default; | ||
$t-margin-block-end-800: 2rem !default; | ||
$t-margin-block-end-1200: 3rem !default; | ||
$t-margin-block-end-1600: 4rem !default; | ||
$t-margin-0: 0; | ||
$t-margin-100: .25rem; | ||
$t-margin-200: .5rem; | ||
$t-margin-400: 1rem; | ||
$t-margin-600: 1.5rem; | ||
$t-margin-800: 2rem; | ||
$t-margin-1200: 3rem; | ||
$t-margin-1600: 4rem; | ||
$t-margin-inline-0: 0; | ||
$t-margin-inline-100: .25rem; | ||
$t-margin-inline-200: .5rem; | ||
$t-margin-inline-400: 1rem; | ||
$t-margin-inline-600: 1.5rem; | ||
$t-margin-inline-800: 2rem; | ||
$t-margin-inline-1200: 3rem; | ||
$t-margin-inline-1600: 4rem; | ||
$t-margin-inline-start-0: 0; | ||
$t-margin-inline-start-100: .25rem; | ||
$t-margin-inline-start-200: .5rem; | ||
$t-margin-inline-start-400: 1rem; | ||
$t-margin-inline-start-600: 1.5rem; | ||
$t-margin-inline-start-800: 2rem; | ||
$t-margin-inline-start-1200: 3rem; | ||
$t-margin-inline-start-1600: 4rem; | ||
$t-margin-inline-end-0: 0; | ||
$t-margin-inline-end-100: .25rem; | ||
$t-margin-inline-end-200: .5rem; | ||
$t-margin-inline-end-400: 1rem; | ||
$t-margin-inline-end-600: 1.5rem; | ||
$t-margin-inline-end-800: 2rem; | ||
$t-margin-inline-end-1200: 3rem; | ||
$t-margin-inline-end-1600: 4rem; | ||
$t-margin-block-0: 0; | ||
$t-margin-block-100: .25rem; | ||
$t-margin-block-200: .5rem; | ||
$t-margin-block-400: 1rem; | ||
$t-margin-block-600: 1.5rem; | ||
$t-margin-block-800: 2rem; | ||
$t-margin-block-1200: 3rem; | ||
$t-margin-block-1600: 4rem; | ||
$t-margin-block-start-0: 0; | ||
$t-margin-block-start-100: .25rem; | ||
$t-margin-block-start-200: .5rem; | ||
$t-margin-block-start-400: 1rem; | ||
$t-margin-block-start-600: 1.5rem; | ||
$t-margin-block-start-800: 2rem; | ||
$t-margin-block-start-1200: 3rem; | ||
$t-margin-block-start-1600: 4rem; | ||
$t-margin-block-end-0: 0; | ||
$t-margin-block-end-100: .25rem; | ||
$t-margin-block-end-200: .5rem; | ||
$t-margin-block-end-400: 1rem; | ||
$t-margin-block-end-600: 1.5rem; | ||
$t-margin-block-end-800: 2rem; | ||
$t-margin-block-end-1200: 3rem; | ||
$t-margin-block-end-1600: 4rem; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
|
||
// Do not edit directly | ||
// Generated on Fri, 21 Oct 2022 11:11:43 GMT | ||
// Generated on Mon, 09 Jan 2023 13:28:25 GMT | ||
|
||
$t-state-focus: #ffcc00 !default; | ||
$t-state-error: #c40606 !default; | ||
$t-state-warning: #f58220 !default; | ||
$t-state-success: #00a69d !default; | ||
$t-state-information: #000000 !default; | ||
$t-state-focus: #ffcc00; | ||
$t-state-error: #c40606; | ||
$t-state-warning: #f58220; | ||
$t-state-success: #00a69d; | ||
$t-state-information: #000000; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
|
||
// Do not edit directly | ||
// Generated on Fri, 21 Oct 2022 11:11:43 GMT | ||
// Generated on Mon, 09 Jan 2023 13:28:25 GMT | ||
|
||
$t-text-primary: #000000 !default; | ||
$t-text-secondary: #666666 !default; | ||
$t-text-reversed: #ffffff !default; | ||
$t-text-primary: #000000; | ||
$t-text-secondary: #666666; | ||
$t-text-reversed: #ffffff; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
// Do not edit directly | ||
// Generated on Fri, 21 Oct 2022 11:11:43 GMT | ||
// Generated on Mon, 09 Jan 2023 13:28:25 GMT | ||
|
||
$t-background-page: #ffffff !default; | ||
$t-background-page: #ffffff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is breaking, should it not be version 32?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexkilgour True, I forgot to sync that when I made it breaking.