-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[amqp] Customizable AmqpBindingFactory #1180
Comments
Welcome to Springwolf. Thanks a lot for reporting your first issue. Please check out our contributors guide and feel free to join us on discord. |
Hi @elysrivero99 We are open to suggestions for better joining patterns for the name (I do not use amqp, if there is a native way to talk about it in amqp, let us know) Also, we marked the beans in core using the annotation [0] but forgot about the plug-ins. |
Hi @timonback, Here is the pull request. Thanks :) |
The change has been merged and will be part of the next release. If you want to try and verify it in your application, use the current Thank you for the report/contribution! |
The change is staged for release and will be part of the next release. If you want to try and verify it in your application today, Thank you for the report/contribution! |
The change is available in the latest release. 🎉 Thank you for the report/contribution and making Springwolf better! |
Describe the feature request
For amqp, the channel name/id is set as "{exchange-name}{routing-key}". In the case that exchange name has "" in the name (i.e: incoming_exchange) and/or the routing key has "_" in the name (an_awesome_rk), the final name of the channel is a bit confusing. In this case the channel will be set as "incoming_exchange_an_awesome_rk".
Would be nice if we have the possibility to create a Custom AmqpBindingFactory overriding the original one, in which, for example, we can decide which char use for delimiting exchange and RKs: ie: an_awesome_rk@incoming_exchange
Technical details
The simplest way of doing this would be marking this bean as
@ConditionalOnMissingBean
The text was updated successfully, but these errors were encountered: