Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amqp] Customizable AmqpBindingFactory #1180

Closed
elysrivero99 opened this issue Feb 12, 2025 · 6 comments
Closed

[amqp] Customizable AmqpBindingFactory #1180

elysrivero99 opened this issue Feb 12, 2025 · 6 comments
Labels
enhancement New feature or request staged for release

Comments

@elysrivero99
Copy link
Contributor

Describe the feature request
For amqp, the channel name/id is set as "{exchange-name}{routing-key}". In the case that exchange name has "" in the name (i.e: incoming_exchange) and/or the routing key has "_" in the name (an_awesome_rk), the final name of the channel is a bit confusing. In this case the channel will be set as "incoming_exchange_an_awesome_rk".

Would be nice if we have the possibility to create a Custom AmqpBindingFactory overriding the original one, in which, for example, we can decide which char use for delimiting exchange and RKs: ie: an_awesome_rk@incoming_exchange

Technical details
The simplest way of doing this would be marking this bean as @ConditionalOnMissingBean

@elysrivero99 elysrivero99 added the enhancement New feature or request label Feb 12, 2025
Copy link

Welcome to Springwolf. Thanks a lot for reporting your first issue. Please check out our contributors guide and feel free to join us on discord.

@timonback
Copy link
Member

Hi @elysrivero99
Thank you for the report.

We are open to suggestions for better joining patterns for the name (I do not use amqp, if there is a native way to talk about it in amqp, let us know)

Also, we marked the beans in core using the annotation [0] but forgot about the plug-ins.
Can you open a PR and mark those beans?

[0] https://github.com/springwolf/springwolf-core/blob/master/springwolf-core/src/main/java/io/github/springwolf/core/configuration/SpringwolfAutoConfiguration.java

@elysrivero99
Copy link
Contributor Author

Hi @timonback,

Here is the pull request.

Thanks :)

@timonback
Copy link
Member

The change has been merged and will be part of the next release.

If you want to try and verify it in your application, use the current SNAPSHOT build as described in our README.md

Thank you for the report/contribution!

Copy link

The change is staged for release and will be part of the next release.

If you want to try and verify it in your application today,
use the latest 1.X.0-SNAPSHOT build as described in our README.md > Testing SNAPSHOT version

Thank you for the report/contribution!

timonback added a commit to timonback/springwolf-core that referenced this issue Feb 14, 2025
sam0r040 pushed a commit that referenced this issue Feb 14, 2025
Copy link

github-actions bot commented Mar 2, 2025

The change is available in the latest release. 🎉

Thank you for the report/contribution and making Springwolf better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request staged for release
Projects
None yet
Development

No branches or pull requests

2 participants