Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SpringwolfKafkaProducer configuration from the user #126

Closed
stavshamir opened this issue Dec 19, 2022 · 3 comments
Closed

Enable SpringwolfKafkaProducer configuration from the user #126

stavshamir opened this issue Dec 19, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@stavshamir
Copy link
Member

No description provided.

@stavshamir stavshamir added the enhancement New feature or request label Dec 19, 2022
@sam0r040
Copy link
Collaborator

sam0r040 commented Jan 17, 2023 •
edited
Loading

Do I understand it correctly, that it should be possible to configure https://docs.spring.io/spring-boot/docs/current/api/org/springframework/boot/autoconfigure/kafka/KafkaProperties.Producer.html in the application configuration to give full control over the KafkaTemplate (independent of what was or was not configured as part of the spring kafka configuration)?

sam0r040 added a commit to sam0r040/springwolf-core that referenced this issue Feb 10, 2023
@sam0r040 @timonback
feat: Configurable springwolf producer for kafka plugin springwolfGH-126
620acf7 


Co-authored-by: Timon Back <[email protected]>
sam0r040 added a commit to sam0r040/springwolf-core that referenced this issue Feb 10, 2023
@sam0r040 @timonback
feat: Configurable springwolf producer for kafka plugin springwolfGH-126
a768398 


Co-authored-by: Timon Back <[email protected]>
@sam0r040 sam0r040 mentioned this issue Feb 10, 2023
Merged
@sam0r040
Copy link
Collaborator

@stavshamir I started working with my interpretation of the feature and added #144 as a proposal

sam0r040 added a commit to sam0r040/springwolf-core that referenced this issue Feb 10, 2023
@sam0r040 @timonback
feat: Configurable springwolf producer for kafka plugin springwolfGH-126
49db4e7 


Co-authored-by: Timon Back <[email protected]>
sam0r040 added a commit to sam0r040/springwolf-core that referenced this issue Mar 10, 2023
@sam0r040 @timonback
feat: Configurable springwolf producer for kafka plugin springwolfGH-126
9e1622b 


Co-authored-by: Timon Back <[email protected]>
timonback added a commit that referenced this issue Mar 12, 2023
@sam0r040 @timonback
feat: Configurable springwolf producer for kafka plugin GH-126 (#144)
ba704db 
* feat: Configurable springwolf producer for kafka plugin GH-126

Co-authored-by: Timon Back <[email protected]>

* Refactor springwolf kafka example to use spring configuration for consumers and produces so that tests can change configuration as needed

* Configure kafka with plain and sasl authentication

* Switch to localhost:9092 as default kafka connection url

* Switch to localhost:9092 as default kafka connection url

---------

Co-authored-by: Timon Back <[email protected]>
Co-authored-by: Timon Back <[email protected]>
@timonback
Copy link
Member

The new version of springwolf has been released. Thank you @sam0r040 for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timonback @stavshamir @sam0r040