Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing KafkaOperationBinding #30

Closed
chris0550 opened this issue Feb 25, 2021 · 2 comments
Closed

Enhancing KafkaOperationBinding #30

chris0550 opened this issue Feb 25, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@chris0550
Copy link

Hello,
maybe it would bring a benefit if we change the GroupId groupId to a more generic type in order to fulfill also other requirements like the clientId.

What do you think about it?

Greetings
Chris

@stavshamir
Copy link
Member

Hi @chris0550, there is another library that implements the entire asyncapi spec for java which I intend to switch to in the future. In the meanwhile if there are some missing fields which are important to you, feel free to provide a PR with the desired changes, your other PRs were very valuable!

@stavshamir stavshamir added the enhancement New feature or request label Dec 7, 2021
@stavshamir
Copy link
Member

stavshamir commented Dec 17, 2021

Now when #33 is closed , this can be closed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants