Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace asyncapi/types with jasyncapi types #33

Closed
5 tasks done
stavshamir opened this issue Oct 11, 2021 · 2 comments
Closed
5 tasks done

Replace asyncapi/types with jasyncapi types #33

stavshamir opened this issue Oct 11, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@stavshamir
Copy link
Member

stavshamir commented Oct 11, 2021

Motivation

Currently, the project uses in-house implementation of the various asyncapi types (such as Channel, Operation etc.).
This in-house implementation is problematic due to:

  1. There are many bindings missing for most of the protocols. Actually only kafka bindings were implemented. For more plugins to be created, we need the bindings for them.
  2. It repeats the great job already done by @Pakisan in jasyncapi.

There for, it would be a great step to replace all those in-house implementations (from asyncapi/types package) with the types provided by jasyncapi-core.

Tasks

  • Add jasyncapi-core dependency
  • Replace all in-house implementations with provided types from jasyncapi. Many have the same names so the switch should be rather smooth, but I did rely on some custom builders, constructors and json serializations that may require additional attention.
  • Fix the tests and verify all pass
  • Remove local asyncapi/tests package (except for ProducerData, which may not belong there, but its future location may be decided later on).
  • Release local snapshot version, and update the kafka plugin. After it is updated, I will release an actual version.
@stavshamir stavshamir added the enhancement New feature or request label Oct 11, 2021
@stavshamir
Copy link
Member Author

@kalarani Would you like to take this?

@kalarani
Copy link
Contributor

Sure @stavshamir . I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants