Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AsyncAPI 2.6.0 from EAP-2 #155

Merged
merged 8 commits into from
Apr 14, 2023

Conversation

Pakisan
Copy link
Contributor

@Pakisan Pakisan commented Mar 16, 2023

Hey, I released new version of library and decided to update it in your awesome project.

Main goal is to update library version, not to adopt 2.6.0 version

tldr; AsyncAPI 2.6.0, new bindings, new security schemes, fixed Schema

Test results:

springwolf-add-ons

➜  springwolf-core git:(feat/asyncapi_2.6.0) ./gradlew :springwolf-add-ons:springwolf-common-model-converters:test

BUILD SUCCESSFUL in 5s
3 actionable tasks: 1 executed, 2 up-to-date

springwolf-core

➜  springwolf-core git:(feat/asyncapi_2.6.0) ./gradlew :springwolf-core:test 

> Task :springwolf-core:test
01:06:23.276 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@19e21f89, started on Fri Mar 17 01:06:22 AMT 2023
01:06:23.279 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@ffd4cba, started on Fri Mar 17 01:06:22 AMT 2023
01:06:23.279 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@6b70d1fb, started on Fri Mar 17 01:06:23 AMT 2023
01:06:23.276 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@6da54910, started on Fri Mar 17 01:06:23 AMT 2023
01:06:23.279 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@22c53d82, started on Fri Mar 17 01:06:22 AMT 2023
01:06:23.276 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@43c7fe8a, started on Fri Mar 17 01:06:23 AMT 2023
01:06:23.279 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@a2b54e3, started on Fri Mar 17 01:06:22 AMT 2023
01:06:23.279 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@29d25e65, started on Fri Mar 17 01:06:22 AMT 2023
01:06:23.279 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@3a4a5f3c, started on Fri Mar 17 01:06:23 AMT 2023
01:06:23.279 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@4dfe8b37, started on Fri Mar 17 01:06:22 AMT 2023
01:06:23.279 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@4293e066, started on Fri Mar 17 01:06:22 AMT 2023
01:06:23.276 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@3709748f, started on Fri Mar 17 01:06:22 AMT 2023
01:06:23.276 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@afde064, started on Fri Mar 17 01:06:23 AMT 2023
01:06:23.276 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@45905bff, started on Fri Mar 17 01:06:21 AMT 2023
01:06:23.279 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@b2c4a8b, started on Fri Mar 17 01:06:22 AMT 2023

BUILD SUCCESSFUL in 7s
4 actionable tasks: 1 executed, 3 up-to-date

springwolf-amqp-plugin

➜  springwolf-core git:(feat/asyncapi_2.6.0) ./gradlew :springwolf-plugins:springwolf-amqp-plugin:test

> Task :springwolf-plugins:springwolf-amqp-plugin:test
01:08:02.196 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@40bb4f87, started on Fri Mar 17 01:08:01 AMT 2023
01:08:02.196 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@21d9cd04, started on Fri Mar 17 01:08:02 AMT 2023
01:08:02.196 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@3569fc08, started on Fri Mar 17 01:08:00 AMT 2023
01:08:02.198 [SpringContextShutdownHook] DEBUG org.springframework.context.support.DefaultLifecycleProcessor - Stopping beans in phase 0
01:08:02.198 [SpringContextShutdownHook] DEBUG org.springframework.context.support.DefaultLifecycleProcessor - Stopping beans in phase 0

BUILD SUCCESSFUL in 6s
5 actionable tasks: 1 executed, 4 up-to-date

springwolf-kafka-plugin

➜  springwolf-core git:(feat/asyncapi_2.6.0) ./gradlew :springwolf-plugins:springwolf-kafka-plugin:test

BUILD SUCCESSFUL in 1s
5 actionable tasks: 5 up-to-date

springwolf-cloud-stream-plugin

➜  springwolf-core git:(feat/asyncapi_2.6.0) ./gradlew :springwolf-plugins:springwolf-cloud-stream-plugin:test

> Task :springwolf-plugins:springwolf-cloud-stream-plugin:test
01:10:14.891 [SpringContextShutdownHook] DEBUG org.springframework.context.support.GenericApplicationContext - Closing org.springframework.context.support.GenericApplicationContext@38f116f6, started on Fri Mar 17 01:10:13 AMT 2023

BUILD SUCCESSFUL in 4s
5 actionable tasks: 1 executed, 4 up-to-date

Looks like I broke ApiIntegrationTest and ApiIntegrationWithDockerTest in examples and can't figure out how

com.fasterxml.jackson.databind.JsonMappingException: Cannot invoke "java.lang.Integer.intValue()" because the return value of "com.asyncapi.v2.binding.operation.amqp.AMQPOperationBinding.getExpiration()" is null (through reference chain: io.github.stavshamir.springwolf.asyncapi.types.AsyncAPI["channels"]->java.util.TreeMap["another-queue"]->com.asyncapi.v2._0_0.model.channel.ChannelItem["publish"]->com.asyncapi.v2._0_0.model.channel.operation.Operation["bindings"]->java.util.TreeMap["amqp"])

closes #156

upd:
Investigation results in the issue

@Pakisan Pakisan marked this pull request as draft March 16, 2023 21:11
Use default serialization provided by jackson
Fix usage of kafka clientId and groupId. The AsyncApi spec expect Schema objects within the bindings, not pure strings.
@Pakisan Pakisan marked this pull request as ready for review April 12, 2023 22:21
@timonback timonback merged commit bc7cd3f into springwolf:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncAPI 2.6.0
3 participants