Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Improved docket configuration #191

Merged

Conversation

ctasada
Copy link
Collaborator

@ctasada ctasada commented May 31, 2023

Looking at the AsyncAPI specification I was missing support to provide the next elements:

  • defaultContentType
  • id

The configuration for defaultContentType was not possible via SpringBoot Properties (only programatically)

Now we can indicate something like springwolf.docket.default-content-type=application/json (or springwolf.docket.defaultContentType=application/json to configure the value

It was not possible to configure the AsyncAPI identifier either (id)

Now we can indicate something like springwolf.docket.id=urn:something:something (or springwolf.docket.id=https://something to configure the identifier value

Carlos Tasada added 2 commits May 31, 2023 15:01
The configuration for `defaultContentType` was not possible via SpringBoot Properties.

Now we can indicate something like `springwolf.docket.default-content-type=application/json` (or `springwolf.docket.defaultContentType=application/json` to configure the value
It was not possible to configure the AsyncAPI identifier

Now we can indicate something like `springwolf.docket.id=urn:something:something` (or `springwolf.docket.id=https://something` to configure the identifier value
@ctasada
Copy link
Collaborator Author

ctasada commented May 31, 2023

If accepted I will update https://github.com/springwolf/springwolf.github.io too

@timonback
Copy link
Member

Perfect. Thank you for this contribution. You are becoming a regular :)

I added a default value for defaultContentType and users only have to overwrite it, when it does not match.

Great that you found the documentation repository.
I am thinking of a new release in the upcoming weeks, so you get to use your contributions shortly.

@timonback timonback merged commit 8cd0163 into springwolf:master Jun 2, 2023
@ctasada ctasada deleted the ctasada/improved-docket-configuration branch December 13, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants