-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Reduce duplicities in configuration #284
chore: Reduce duplicities in configuration #284
Conversation
✅ Deploy Preview for springwolf-ui canceled.
|
Some `dependencies.gradle` variables were no longer used.
Now that all the modules are aligned, we can define the version a single time.
``` Execution failed for task ':analyzeClassesDependencies'. > Dependency analysis found issues. unusedDeclaredArtifacts: ``` Some dependencies were not used or were used, but wrongly identified as not used.
Move the Java version definition to the project's root
Centralize the Maven publishing configuration to remove duplicated configuration.
Centralize the Signing configuration to remove duplicated configuration.
f75e22e
to
8a4b07d
Compare
Centralize the version value used in the `docker-compose`
8a4b07d
to
c8b6876
Compare
Hi @ctasada, I like to keep the information whether it is a snapshot separate from What I am currently unsure about is how to handle bugfix releases. |
Now that we have the `docker-compose.yaml` files reading from a `.env` file, we can use the same file to configure Gradle. This provides a single point to configure the version for the whole project.
d83fb9b
to
da5bb47
Compare
@timonback Regarding the bug fixing after releases I think the best approach is to link the release with a I see 2 ways of accomplishing it: Both approaches accomplish the same outcome, but are implemented in slightly different ways. I see that Github has different workflows in the marketplace that accomplish this. I have used both approaches with Gitlab for years and they work fine. The decision is mainly driven by minor tradeoffs and deployment preferences. |
Continuation of springwolf#284 After suggested in springwolf#284 (comment)
* chore: Simplify handling of SNAPSHOT versions Continuation of #284 After suggested in #284 (comment) * chore: Simplify publish-releases pipeline
With the recent changes in #267 now is possible to reduce duplication of values.
Now the version is reduced to a single
build.gradle
configuration. Same for other module configurations that are also unified.While testing I also found some unneeded variables in
dependencies.gradle
and someunusedDeclaredArtifacts
which are also fixed.Each change is in its own commit to allow for easier review.