chore: remove deprecated asyncapidocket bean #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for springwolf-ui canceled.
|
ctasada
approved these changes
Jan 7, 2024
...rc/main/java/io/github/stavshamir/springwolf/configuration/DefaultAsyncApiDocketService.java
Outdated
Show resolved
Hide resolved
timonback
added a commit
to timonback/springwolf-core
that referenced
this pull request
Jan 12, 2024
This reverts commit c4ea459.
sam0r040
pushed a commit
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AsyncApiDocket still exists as a data holder, but is not used as a bean anymore.
I wonder, whether the is the need for this class at all. Alternatively, services can access the SpringwolfProperties directly. But that can be potentially unstable in the long run as well.