Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for manual consumer definition. #77

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Allow for manual consumer definition. #77

merged 3 commits into from
Jun 23, 2022

Conversation

jrlambs
Copy link
Contributor

@jrlambs jrlambs commented Jun 21, 2022 •
edited
Loading

Adds new ConsumerData classes for amqp and kafka.
allows for manual definition of the consumers using new ConsumerData classes.

@stavshamir
Copy link
Member

This looks quite good!
I don't think it has to be any more complicated than this at this point.
Just make sure that you add unit tests and fix the existing integration tests and that all variable/function names has been changed from producer.
The documentation goes in the site repo.

@jrlambs jrlambs marked this pull request as ready for review June 22, 2022 23:14
@stavshamir stavshamir merged commit 7e81bb8 into springwolf:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrlambs @stavshamir