This repository has been archived by the owner on Jun 18, 2023. It is now read-only.
New badges #21
Merged
New badges #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrlambs
commented
Oct 14, 2022
jrlambs
commented
- sort channels by protocol, operation, and name
- split operation badge from protocol badge
- add icon to operation badge
and "consumer" -> "subscribe"
split operation badge from protocol badge add icon to operation badge
# Conflicts: # src/app/shared/asyncapi.service.ts
timonback
approved these changes
Oct 14, 2022
| color: #fff | ||
| } | ||
|
|
||
| .fa { |
There was a problem hiding this comment.
Such a generic class will apply to font-awesome icons on the page.
I suggest making it a bit more selective
Suggested change
| .fa { | |
| .badge .fa { |
| this.asyncApiService.getAsyncApis().subscribe(asyncapi => this.channels = asyncapi.get(name).channels); | ||
| this.asyncApiService.getAsyncApis().subscribe(asyncapi => { | ||
| this.channels = this.sortChannels(asyncapi.get(name).channels); | ||
| console.log(this.channels); |
There was a problem hiding this comment.
Suggested change
| console.log(this.channels); |
Probably not needed anymore :)
| } | ||
|
|
||
|
|
||
| private sortByProperty(toSort: Array<any>, property: string) { |
| @@ -123,6 +123,8 @@ export class AsyncApiService { | |||
| private mapOperation(operationName: string, message: Message, bindings?: any): Operation { | |||
| return { | |||
| type: this.getProtocol(bindings) + operationName, | |||
There was a problem hiding this comment.
As the type got split, is it possible to remove the field?
|
Closes #20 |
|
Looks great, thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.