Skip to content
This repository has been archived by the owner on Jun 18, 2023. It is now read-only.

Remove multiple documents support #23

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

stavshamir
Copy link
Member

After removing the title from the document on the backend, the UI which expected a map of string -> doc breaks.
I originally added support for multiple documents to enable loading of multiple docs of different services in a standalone app, but it is not in use (and far from being usable), so I decided to remove it for now.

@stavshamir stavshamir requested a review from timonback October 15, 2022 18:01
@timonback
Copy link
Member

Superseeds #8

Copy link
Member

@timonback timonback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As the mocks are changed in indentation, this can be a chance to update the mocks with npm run update-mocks.
To view future diffs to the mocks, maybe we should change the indentation setting in springwolf-core or leave them as is?

@stavshamir
Copy link
Member Author

Let's change the indentation in springwolf-core. We can also add npm run update-mocks to the github workflow so it is automatic

@stavshamir stavshamir merged commit 1a8654a into master Oct 15, 2022
@stavshamir stavshamir deleted the feature/remove-multiple-doc-support branch October 15, 2022 18:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants