You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With PR#266, we introduced the ability to define contract calls together with native deposit. As SDK didn't integrate the initial implementation of native handlers, it needs to be expanded so it can be used to create:
Deposit of native currency (tokens)
Deposit of native currency (tokens) + contract call definition
The Native flow differs slightly from regular ERC20/721/1155, as the deposit transaction should not land on Bridge.sol but on NativeAdapter.sol contract. We have already expanded the testnetshared configuration to have this as a new property of the domain - nativeTokenAdapter.
Testing details
Unit Tests: Develop unit tests that cover scenarios where both Native transfers and contract calls are involved.
Error Handling: Test how the SDK handles invalid or failed contract calls within the transaction flow.
Acceptance Criteria
The SDK supports interactions with the new NativeAdapter->NativeHandler, allowing for both Native transfers and optional contract calls within the same transaction.
The SDK maintains backward compatibility and continues to function as expected with existing handlers.
All new functionality is covered by tests, ensuring reliable and consistent behavior.
The text was updated successfully, but these errors were encountered:
#545)
# Implementation details
With [PR#266](sprintertech/sygma-solidity#266),
we introduced the ability to define contract calls together with native
deposit. As SDK didn't integrate the initial implementation of native
handlers, it needs to be expanded so it can be used to create:
Deposit of native currency (tokens)
Deposit of native currency (tokens) + contract call definition
The Native flow differs slightly from regular ERC20/721/1155, as the
deposit transaction should not land on Bridge.sol but on
NativeAdapter.sol contract. We have already expanded the testnet [shared
configuration to have this as a new property of the
domain](https://github.com/sygmaprotocol/sygma-shared-configuration/blob/main/testnet/shared-config-test.json#L10)
- nativeTokenAdapter.
## Closes: #521
# Testing details
Unit Tests: Develop unit tests that cover scenarios where both Native
transfers and contract calls are involved.
Error Handling: Test how the SDK handles invalid or failed contract
calls within the transaction flow.
# Acceptance Criteria
- [ ] The SDK supports interactions with the new
NativeAdapter->NativeHandler, allowing for both Native transfers and
optional contract calls within the same transaction.
- [ ] The SDK maintains backward compatibility and continues to function
as expected with existing handlers.
- [ ] All new functionality is covered by tests, ensuring reliable and
consistent behavior.
Implementation details
With PR#266, we introduced the ability to define contract calls together with native deposit. As SDK didn't integrate the initial implementation of native handlers, it needs to be expanded so it can be used to create:
The Native flow differs slightly from regular ERC20/721/1155, as the deposit transaction should not land on
Bridge.sol
but onNativeAdapter.sol
contract. We have already expanded thetestnet
shared configuration to have this as a new property of the domain -nativeTokenAdapter
.Testing details
Acceptance Criteria
NativeAdapter
->NativeHandler
, allowing for both Native transfers and optional contract calls within the same transaction.The text was updated successfully, but these errors were encountered: