fix: added ethereum transaction overrides #534

saadahmsiddiqui · 2024-09-12T09:51:32Z

Description

This PR adds the optional ethereum transaction parameters to Sygma fungible transfer classes.

[X] Unit test detecting gasPrice and gasLimit

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation

I have ensured that all acceptance criteria (or expected behavior) from issue are met
I have added tests to cover my changes.
I have ensured that all the checks are passing and green, I've signed the CLA bot

…)` and `getApprovalTransactions()`

🤖 I have created a release *beep* *boop* --- ## [1.3.2](evm-v1.3.1...evm-v1.3.2) (2024-09-19) ### Bug Fixes * added ethereum transaction overrides ([#534](#534)) ([478c15c](478c15c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

fix: added ethereum transaction overrides to `getTransferTransaction(…

c0f0178

…)` and `getApprovalTransactions()`

Lykhoyda previously approved these changes Sep 12, 2024

View reviewed changes

fix import type

9bd8104

saadahmsiddiqui dismissed Lykhoyda’s stale review via 9bd8104 September 12, 2024 12:45

fix import

ebf6384

saadahmsiddiqui requested a review from Lykhoyda September 12, 2024 12:49

saadahmsiddiqui added 2 commits September 12, 2024 15:55

transaction extras

baeda23

lint fix

97389d0

Lykhoyda approved these changes Sep 13, 2024

View reviewed changes

MakMuftic approved these changes Sep 16, 2024

View reviewed changes

saadahmsiddiqui merged commit 478c15c into main Sep 19, 2024
3 checks passed

saadahmsiddiqui deleted the fix/evm-transaction-overrides branch September 19, 2024 08:56

MakMuftic mentioned this pull request Sep 19, 2024

chore(main): release evm 1.3.2 #544

Merged