Wrong exception when .git/hooks directory missing #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -587,9 +587,12 @@ class SprintlyTool: | |||
|
|
|||
| # ensure the current directory is a git repository | |||
| directory = os.getcwd() | |||
| git_directory = hooks_directory = os.path.join(directory, '.git') | |||
There was a problem hiding this comment.
Instead of doing multiple assignments (eg git_directory = hooks_directory = ..., just use git_directory as the base on line 591 instead of directory.
Otherwise, this looks solid.
|
Is that better @justinabrahms ? |
|
I suspect this might close Issue 32 |
justinabrahms
added a commit
that referenced
this pull request
Mar 17, 2015
Wrong exception when .git/hooks directory missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The follow issue can be closed using the code in this pull request.
This should check both:
hooks/directoryDifferent exceptions are raised for each and should give the user more clues to fixing the issue.