Use URI type for verificationMethod option #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clehner
force-pushed
the
fix/verification-method-uri
branch
from
2735864 to
7d486bf
Compare
sbihel
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use URI type in proof options for verificationMethod. This means that the verificationMethod option, such as for credential issuance and verification, will be fallibly converted to the URI type, to preventing non-URI use of the option. Currently the URI validation is incomplete as it just checks that the string contains ":", but this is enough for the test case in
vc-http-api, and can be further improved. This also doesn't validate dereferencing the verification method URI during issuance; that is not required currently but we might want to consider doing so.This is a breaking change and requires a corresponding change in
didkit: spruceid/didkit#184Close #144