JWK and Verification method refactor #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbihel
approved these changes
Aug 26, 2021
- Generalize matching a JWK against a VM map - Implement comparing a JWK by public key properties
clehner
force-pushed
the
feat/vm-jwk-refactor
branch
from
25e4186 to
c188ab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are factored out of #253.
Verifying a public key against a blockchainAccountId in some proof types is here generalized to verifying the public key against the verification method map, including allowing the verification method map to use a literal public key instead of only blockchainAccountId.