Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default proof type selection #475

Merged
merged 2 commits into from
Oct 18, 2022
Merged

fix default proof type selection #475

merged 2 commits into from
Oct 18, 2022

Conversation

chunningham
Copy link
Contributor

Since #253 we have had good automatic defaults for verificationMethod and verificationRelationship, however auto-defaults didn't work for type as long as the signature suite was chosen prior to ensure_or_pick_verification_relationship, as that fn modifies options.type_ to be appropriate.

Copy link
Contributor

@cobward cobward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... ensure_or_pick_verification_relationship, as that fn modifies options.type_ to be appropriate.

I assume this is a typo, but just to make sure: that fn doesn't modify options.type_, but it can modify options.verification_method. Is this sufficient to improve the default proof type selection?

ssi-ldp/src/lib.rs Show resolved Hide resolved
Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really knowledgeable about that part but it seems reasonable

@chunningham chunningham merged commit 0580576 into main Oct 18, 2022
@chunningham chunningham deleted the fix/default-type branch October 18, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants