PR: Add menu bar to notebook #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, you can look at the menu bar but it does not yet do anything useful.
|
Awesome work :-) |
|
I agree, great work @jitseniesen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a menu bar to the rendered notebook and removes the side bar with the command palette. The menu bar is filled with items defined in the notebook component of Jupyter lab.
Compared to Jupyter lab, the File, Tab, Settings and Help menus are missing. These are defined in other components so they are not so easy to include, and in many cases they require thought on how to integrate them properly in Spyder.
Fixes #270.