PR: Restore notebooks that were open at end of last session #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, create the welcome tab in the plugin at startup. This makes for a cleaner API.
Add a convenience function NotebookTabWidget.is_newly_created(). Use this function in the code. Add tests.
This functionality was broken by mistake in commit 5e915fb.
Add a convenience function NotebookTabWidget.is_welcome_client(). Use this function in the code. Add tests.
jitseniesen
force-pushed
the
remember-opened
branch
from
6c0fc90 to
baa8186
Compare
jitseniesen
force-pushed
the
remember-opened
branch
from
baa8186 to
b38b9ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Spyder store the file names of the notebooks that were open at the end of a session when the plugin is closed. The next time Spyder opens, the plugin will open these notebooks again. As before, notebooks with names like
untitled0.ipynbin the temporary directory are deleted, so these will not be opened at the start of the next session. If there are no notebooks to be opened at the start of a session, the plugin will open a newly created notebook and display the welcome tab.This PR also adds some tests and convenience functions for identifying the welcome tab and untitled, newly created notebooks.
Fixes #68.