-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Implement dark theme #297
Conversation
Codecov Report
|
@jitseniesen, it looks pretty awesome! Keep up with the good work here. |
The server component has changed enough that we can claim partial copyright.
For some reason, spyder-notebook remains to have a white background even when Spyder is set to dark. I installed the latest spyder-notebook from conda. |
@kingwatam Can you please check the version of spyder-notebook that is reported in |
I couldn't find spyder-notebook under dependencies, even though I had the notebook tab in Spyder. However, I could find spyder-notebook in Anaconda Navigator, version 0.2.3. That must be why. After uninstalling Spyder (4.0.1), and reinstalling it (4.1.5), as well as reinstalling spyder-notebook (0.3.1), it now works as expected. Thanks for the help! |
This PR renders notebooks using the JupyerLab dark theme if the Spyder interface is set to dark.
It was not such a big change in the end but I learned a lot about JupyterLab, TypeScript and webpack in the process. You will see that the colour scheme of the JupyterLab dark theme is a bit different from Spyder: the text of the notebook pane is whiter and the background is blacker than in the other panes.