PR: Wait a bit repeatedly after save before reading notebook #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When saving a newly created notebook in a temporary directory, we read it back to check whether it is empty; if not, we offer to save it in a more permanent location. Before, we waited one second between initiating the save and reading it back. Now, we wait 0.25 second, but keep trying if the file does not yet exist. This means the function runs faster if the save is expedient and it waits longer if the save runs slowly.
This is a refactor.
Codecov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving a newly created notebook in a temporary directory, we read it back to check whether it is empty; if not, we offer to save it in a more permanent location. Before, we waited one second between initiating the save and reading it back. Now, we wait 0.25 second, but keep trying if the file does not yet exist. This means the function runs faster if the save is expedient and it waits longer if the save runs slowly.
The first commit in the PR is the one providing the functionality, the other commits are refactoring and adding tests.
Fixes #339.