PR: Specify file for storing connection info when starting server #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a command line parameter to the notebook server for specifying the file in which connection information is to be stored. Use this parameter to set the file name to spynbserver-NNNN-MM.json where NNNN is the PID of the Spyder process and MM distinguishes between the notebook servers started by Spyder. The reason for this is that Jupyter by default uses nbserver-XXXX.json where XXXX is the PID of the notebook server process, but in a venv in Windows there is no good method for finding this PID.
jitseniesen
changed the title
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files
|
ccordoba12
reviewed
Mar 31, 2023
There was a problem hiding this comment.
Some suggestions to make the code a bit more readable, otherwise looks good to me @jitseniesen.
This is part of the change in the previous commit: In a venv on Windows, the server process is different from the process that starts the server.
Suggestion from code review. Co-authored-by: Carlos Cordoba <[email protected]>
Thanks. It would probably have been easier for you to simply add one comment to rename |
|
Ok, will do for next time. |
ccordoba12
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a command line parameter to the notebook server for specifying the file in which connection information is to be stored. Use this parameter to set the file name to spynbserver-NNNN-MM.json where NNNN is the PID of the Spyder process and MM distinguishes between the notebook servers started by Spyder.
The reason for this is that Jupyter by default uses nbserver-XXXX.json where XXXX is the PID of the notebook server process, but in a venv in Windows there is no good method for finding this PID.
Fixes #398