PR: Update plugin to Spyder 6 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This signal was removed in Spyder 6 and AFAICT it did not have any use.
|
The idea with the new Switcher plugin is that other plugins can depend on it in the same way that they depend on the MainMenu or Toolbar plugins. So, you need to add the Switcher to the OPTIONAL list of plugins and declare methods decorated with on_plugin_available and on_plugin_teardown for it |
|
Thanks. I have this information in my brain somewhere, but it did not come out when I wrote the PR. Oops! |
|
No problem. I figured you missed that one because the new Switcher plugin has the same API as the old Switcher widget. Plus, we left a reference to |
ccordoba12
approved these changes
Apr 27, 2023
In particular, disconnect signals and kill the server if it is still starting up. This may avoid errors in the CI testing.
This was referenced May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was quite simple, the main change is to adapt to the Switcher plugin.
Fixes #278.