PR: Add check_compatibility for PyQt4 and WebEngine #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
changed the title
ccordoba12
reviewed
Jun 27, 2017
spyder_notebook/notebookplugin.py
Outdated
| message = '' | ||
| value = True | ||
| if PYQT4 or WEBENGINE: | ||
| message = _("You are working with Qt4 or WebEngine. <br><br>" |
There was a problem hiding this comment.
Instead of WebEngine, let's say here
... Qt4 or the PyQt5 wheels.
ccordoba12
reviewed
Jun 27, 2017
spyder_notebook/notebookplugin.py
Outdated
| if PYQT4 or WEBENGINE: | ||
| message = _("You are working with Qt4 or WebEngine. <br><br>" | ||
| "In order to make the Notebook plugin work " | ||
| "you should update to Qt5 and use WebKit.") |
There was a problem hiding this comment.
Also this to
... to Qt5 and/or use Anaconda or Miniconda.
ccordoba12
reviewed
Jun 27, 2017
spyder_notebook/notebookplugin.py
Outdated
| self.main.add_to_fileswitcher(self, self.tabwidget, self.clients, | ||
| QIcon(icon_path)) | ||
| self.recent_notebook_menu.aboutToShow.connect(self.setup_menu_actions) | ||
| if self.check_compatibility()[0]: |
There was a problem hiding this comment.
Is this really necessary? I thought the plugin won't be registered if check_compatibility is True.
There was a problem hiding this comment.
Yep, if not the plugin will be visible, although the message of incompatibility will be also displayed
There was a problem hiding this comment.
This is an error in Spyder then. I'll open an issue so you can help me to fix it.
ccordoba12
reviewed
Jun 28, 2017
spyder_notebook/notebookplugin.py
Outdated
| if PYQT4 or WEBENGINE: | ||
| message = _("You are working with Qt4 or the PyQt5 wheels." | ||
| "<br><br>In order to make the Notebook plugin " | ||
| "work you should update to Qt5 and/or use " |
ccordoba12
changed the title
ccordoba12
reviewed
Jun 28, 2017
spyder_notebook/notebookplugin.py
Outdated
| @@ -12,6 +12,8 @@ | |||
| import sys | |||
|
|
|||
| # Qt imports | |||
| from qtpy import PYQT4 | |||
| from qtpy.QtWebEngineWidgets import WEBENGINE | |||
There was a problem hiding this comment.
This import needs to be before the qtpy.QtWidgets one, so that they are organized alphabetically.
There was a problem hiding this comment.
Should I move the import for qtpy.QtCore and qtpy.compat too?
|
Yes, please. Reorganize them so that they come alphabetically.
El 27/06/17 a las 23:26, Daniel Althviz Moré escribió:
…
***@***.**** commented on this pull request.
------------------------------------------------------------------------
In spyder_notebook/notebookplugin.py
<#78 (comment)>:
> @@ -12,6 +12,8 @@
import sys
# Qt imports
+from qtpy import PYQT4
+from qtpy.QtWebEngineWidgets import WEBENGINE
Should I move the import for |qtpy.QtCore| and |qtpy.compat| too?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#78 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWS7WOS6MWsOeAztOMtkVVkZUk9ktncks5sIdYNgaJpZM4OHKz1>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74