-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add menuBar with the actions available to each tab #89
Conversation
@dalthviz screenshots please :-) |
Please post the icons at the top of each tab and not at the bottom. Also, please don't the Open recent action and remove the + button from tabs right corner. |
That looks very weird @ccordoba12 :-\ |
Should we post those icons next to the notebook tabs then? |
I just want to give people a way to understand that they need to use those icons instead of the regular ones, at least for now. |
Icons plus a menu bar plus more icons.... that is just too much :-\ |
So what do you propose? Leave things as they are? I mean, if people try to use the open dialog from Spyder's regular toolbar, they will find that their notebooks are open in the Editor, not in the notebook pane. I mention this because it happened to a person I was helping to install the notebook during SciPy. |
I agree with @goanpeca here. I don't mind too much as a short-term fix for putting a release of the plugin out, but for the medium term I don't think it is a good idea to have to have two New buttons, two Open buttons, etc.
It should be possible to have the Open button from Spyder's toolbar open notebooks in the Notebook pane and other files in the Editor pane; is there a problem with that? If there is a use case for opening notebooks in the Editor pane, then we may add a button to the Open dialog box to allow this. |
Ok, I agree with both of you then. Sorry @dalthviz to make you waste your time :-/
Not exactly. Right now that requires changes to Spyder itself, while it'd be better for this plugin to register a handler with the Spyder Open action. We should go with the first approach in Spyder 3, but we'd like to implement the second one in Spyder 4. |
Fixes #88