Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add menuBar with the actions available to each tab #89

Closed
wants to merge 2 commits into from

Conversation

dalthviz
Copy link
Member

Fixes #88

@dalthviz dalthviz added this to the v0.1 milestone Jul 17, 2017
@dalthviz dalthviz self-assigned this Jul 17, 2017
@dalthviz dalthviz requested a review from ccordoba12 July 17, 2017 22:29
@goanpeca
Copy link
Member

@dalthviz screenshots please :-)

@dalthviz
Copy link
Member Author

Preview:

imagen

@ccordoba12
Copy link
Member

Please post the icons at the top of each tab and not at the bottom. Also, please don't the Open recent action and remove the + button from tabs right corner.

@dalthviz
Copy link
Member Author

Preview:

imagen

@goanpeca
Copy link
Member

That looks very weird @ccordoba12 :-\

@ccordoba12
Copy link
Member

Should we post those icons next to the notebook tabs then?

@ccordoba12
Copy link
Member

I just want to give people a way to understand that they need to use those icons instead of the regular ones, at least for now.

@goanpeca
Copy link
Member

Icons plus a menu bar plus more icons.... that is just too much :-\

@ccordoba12
Copy link
Member

So what do you propose? Leave things as they are?

I mean, if people try to use the open dialog from Spyder's regular toolbar, they will find that their notebooks are open in the Editor, not in the notebook pane.

I mention this because it happened to a person I was helping to install the notebook during SciPy.

@jitseniesen
Copy link
Member

Icons plus a menu bar plus more icons.... that is just too much :-\

I agree with @goanpeca here. I don't mind too much as a short-term fix for putting a release of the plugin out, but for the medium term I don't think it is a good idea to have to have two New buttons, two Open buttons, etc.

I mean, if people try to use the open dialog from Spyder's regular toolbar, they will find that their notebooks are open in the Editor, not in the notebook pane.

It should be possible to have the Open button from Spyder's toolbar open notebooks in the Notebook pane and other files in the Editor pane; is there a problem with that? If there is a use case for opening notebooks in the Editor pane, then we may add a button to the Open dialog box to allow this.

@ccordoba12 ccordoba12 removed this from the v0.1 milestone Jul 18, 2017
@ccordoba12
Copy link
Member

I agree with @goanpeca here. I don't mind too much as a short-term fix for putting a release of the plugin out

Ok, I agree with both of you then. Sorry @dalthviz to make you waste your time :-/

It should be possible to have the Open button from Spyder's toolbar open notebooks in the Notebook pane and other files in the Editor pane; is there a problem with that?

Not exactly. Right now that requires changes to Spyder itself, while it'd be better for this plugin to register a handler with the Spyder Open action. We should go with the first approach in Spyder 3, but we'd like to implement the second one in Spyder 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants