PR: Fix several small issues in our test suite #17092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make sense to do that since it's not possible to obtain min/max for that kind of arrays.
|
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-12-25 17:35:49 UTC |
ccordoba12
force-pushed
the
fix-test-suite
branch
from
89bd084 to
c502f3b
Compare
That avoids segfaults when running tests that use it in isolation
This was not working as expected in our tests.
ccordoba12
force-pushed
the
fix-test-suite
branch
from
c502f3b to
cd2616a
Compare
ccordoba12
added a commit
that referenced
this pull request
Dec 25, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fix segfaults, flaky and failing tests, and tests that were not working with newer Python versions.
Issue(s) Resolved
Fixes #17090
Fixes #17084
Fixes #17080
Fixes #17069
Fixes #17067
Fixes #17059
Fixes #17058
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12